-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add IBM watsonx AI provider in the list of providers to connect to IBM hosted LLMs #8321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add IBM watsonx AI provider in the list of providers to connect to IBM hosted LLMs #8321
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found several issues that need attention before merge. See inline comments for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I took a look at the changes and found a couple of issues that need to be addressed.
|
@daniel-lxs I have addressed your feedback. Thanks for the review. It should be ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention before merge. See inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention before merge. See inline comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention before merge. See inline comments for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention before merge. See inline comments for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found some issues that need attention before merge. See inline comments for details.
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
Co-authored-by: roomote[bot] <219738659+roomote[bot]@users.noreply.github.com>
- Reduce UI component from 470 to 313 lines (33% reduction) - Remove redundant manual refresh button (follows LMStudio/Ollama pattern) - Extract validation helper function to reduce duplication - Consolidate duplicate credential input fields - Fix region naming to use actual codes instead of pretty names - Simplify handler variable declarations and error handling - Remove redundant validation checks in fetcher - Add documented constant for non-inference model filtering - Overall 19% reduction across all watsonx files (913 -> 735 lines)
- Removed watsonx-specific logic from DiffSettingsControl component - Removed 'advanced.diff.watsonx.description' translation key from all 18 language files - IBM watsonx provider has nothing to do with diff settings
* feat: convert Chutes to dynamic/router provider - Add chutes to dynamicProviders array in provider-settings - Add chutes entry to dynamicProviderExtras in api.ts - Create fetcher function for Chutes models API - Convert ChutesHandler to extend RouterProvider - Update tests to work with dynamic provider setup - Export chutesDefaultModelInfo for RouterProvider constructor * fix: address security and code quality issues from review - Fix potential API key leakage in error logging - Add temperature support check before setting temperature - Improve code consistency with RouterProvider patterns * fix: add chutes to routerModels initialization - Fix TypeScript error in webviewMessageHandler - Ensure chutes is included in RouterName Record type * Fixes * Support reasoning * Fix tests * Remove reasoning checkbox --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: Matt Rubens <[email protected]>
* feat: convert Chutes to dynamic/router provider - Add chutes to dynamicProviders array in provider-settings - Add chutes entry to dynamicProviderExtras in api.ts - Create fetcher function for Chutes models API - Convert ChutesHandler to extend RouterProvider - Update tests to work with dynamic provider setup - Export chutesDefaultModelInfo for RouterProvider constructor * fix: address security and code quality issues from review - Fix potential API key leakage in error logging - Add temperature support check before setting temperature - Improve code consistency with RouterProvider patterns * fix: add chutes to routerModels initialization - Fix TypeScript error in webviewMessageHandler - Ensure chutes is included in RouterName Record type * Fixes * Support reasoning * Fix tests * Remove reasoning checkbox --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: Matt Rubens <[email protected]>
* feat: convert Chutes to dynamic/router provider - Add chutes to dynamicProviders array in provider-settings - Add chutes entry to dynamicProviderExtras in api.ts - Create fetcher function for Chutes models API - Convert ChutesHandler to extend RouterProvider - Update tests to work with dynamic provider setup - Export chutesDefaultModelInfo for RouterProvider constructor * fix: address security and code quality issues from review - Fix potential API key leakage in error logging - Add temperature support check before setting temperature - Improve code consistency with RouterProvider patterns * fix: add chutes to routerModels initialization - Fix TypeScript error in webviewMessageHandler - Ensure chutes is included in RouterName Record type * Fixes * Support reasoning * Fix tests * Remove reasoning checkbox --------- Co-authored-by: Roo Code <[email protected]> Co-authored-by: Matt Rubens <[email protected]>
24697be to
a1221b1
Compare
Related GitHub Issue
Closes: #8087
Roo Code Task Context (Optional)
Description
Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Adds IBM watsonx as a new AI provider with full integration, including configuration, validation, UI support, and testing.
provider-settings.tsandglobal-settings.ts.WatsonxAIHandlerinibm-watsonx.tsfor handling API interactions.ibmCloudandcloudPakplatforms with different authentication methods.validate.tsto include validation for IBM watsonx configurations.validate.test.tsfor IBM watsonx.ApiOptions.tsxandproviders/ibm-watsonx.tsxto support IBM watsonx configurations.WatsonxAIHandlerinibm-watsonx.spec.ts.webviewMessageHandler.spec.tsandClineProvider.spec.tsto include IBM watsonx.This description was created by
for 68c8418. You can customize this summary. It will automatically update as commits are pushed.